Emmanuele Bassi [Mon, 8 Nov 2021 10:14:48 +0000 (10:14 +0000)]
Unrealize ATContext on unroot
Non-root widgets should unrealize their ATContext, if they have one,
when they are unrooted, as they don't have a connection to a top level
any more.
Fixes: #4421
Daniel Mustieles [Mon, 8 Nov 2021 09:32:50 +0000 (10:32 +0100)]
Updated Spanish translation
Emmanuele Bassi [Sun, 7 Nov 2021 23:40:14 +0000 (23:40 +0000)]
Merge branch 'ebassi/for-master' into 'master'
docs: Fix typo in link
See merge request GNOME/gtk!4135
Emmanuele Bassi [Sun, 7 Nov 2021 23:23:36 +0000 (23:23 +0000)]
docs: Fix typo in link
Hugo Carvalho [Sun, 7 Nov 2021 21:30:40 +0000 (21:30 +0000)]
Update Portuguese translation
Hugo Carvalho [Sun, 7 Nov 2021 21:27:49 +0000 (21:27 +0000)]
Update Portuguese translation
Emmanuele Bassi [Sun, 7 Nov 2021 19:08:16 +0000 (19:08 +0000)]
Merge branch 'ebassi/docs-link-fixes' into 'master'
docs: Fix wrong fragments in type links
See merge request GNOME/gtk!4134
Emmanuele Bassi [Sun, 7 Nov 2021 18:22:10 +0000 (18:22 +0000)]
docs: Fix wrong fragments in type links
Due to a bug in gi-docgen we're not getting a warning if a fragment to a
type does not match the actual type, and we're generating a broken link.
See: https://gitlab.gnome.org/GNOME/gi-docgen/-/merge_requests/120
Emmanuele Bassi [Sun, 7 Nov 2021 18:21:28 +0000 (18:21 +0000)]
Merge branch 'these-are-flags' into 'master'
docs: Tag Gdk.ModifierType as flags
See merge request GNOME/gtk!4133
Marco Melorio [Sun, 7 Nov 2021 17:14:15 +0000 (18:14 +0100)]
docs: Tag Gdk.ModifierType as flags
Yuri Chornoivan [Sat, 6 Nov 2021 04:16:55 +0000 (04:16 +0000)]
Update Ukrainian translation
Benjamin Otte [Sat, 6 Nov 2021 03:54:08 +0000 (03:54 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
boxlayout: Be more careful with what to consider natural size
See merge request GNOME/gtk!4129
Benjamin Otte [Sat, 6 Nov 2021 02:38:03 +0000 (03:38 +0100)]
reftests: Add reftest for last 2 issues
Use a label that is long enough to require wrapping and force it into a
hardcoded width. Use a sentence where all the words have the same size
to not get unwanted wrapping behavior.
Also append a 2nd row to check that the first row gets the proper height
allocated.
Found by Marco Melorio.
Benjamin Otte [Sat, 6 Nov 2021 02:15:04 +0000 (03:15 +0100)]
label: Don't deduce label width from logical rect
The width of a logical rect after line breaking is sometimes not
wide enough to cause line breaking to break at the exact same points.
(Is that by design or a bug in Pango? I don't know.)
So don't use the width, and only relyon values we actually set to
pango_layout_set_width().
Benjamin Otte [Fri, 5 Nov 2021 23:56:11 +0000 (00:56 +0100)]
boxlayout: Be more careful with what to consider natural size
Don't just use the natural size as the max size, the natural size
is the ideal size, not necessarily the maximum size.
Also check the nat size for opposite min size.
Matthias Clasen [Fri, 5 Nov 2021 23:08:56 +0000 (23:08 +0000)]
Merge branch 'remove_some_unused_declarations' into 'master'
remove some unused declarations
See merge request GNOME/gtk!4125
Matthias Clasen [Fri, 5 Nov 2021 23:08:28 +0000 (23:08 +0000)]
Merge branch 'wip/baedert/for-master' into 'master'
paned: Don't pass values < -1 to gtk_widget_measure()
Closes #4404
See merge request GNOME/gtk!4126
Benjamin Otte [Fri, 5 Nov 2021 22:11:00 +0000 (22:11 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
Revert "label: Never measure more than max-width-chars"
Closes #4399
See merge request GNOME/gtk!4120
Benjamin Otte [Fri, 5 Nov 2021 19:51:00 +0000 (20:51 +0100)]
picture: Setting can-shrink requires a resize
So queue one.
Matthias Clasen [Fri, 5 Nov 2021 19:41:05 +0000 (19:41 +0000)]
Merge branch 'yurchor-master-patch-77064' into 'master'
Fix minor typo: Unsupportd -> Unsupported
See merge request GNOME/gtk!4127
Benjamin Otte [Fri, 5 Nov 2021 19:30:49 +0000 (20:30 +0100)]
boxlayout: Compute opposite size properly
For size -1 in the opposite orientation, GtkBoxLayout used to measure
the children based on their min size in the box's orientation instead of
-1. That wasn't really intended, but was a side effect of how the sizing
code did (not) distribute extra size above the minimum size.
This is clearly not what we want.
What we want is measuring the orientation as is for size -1. Then we
want to just take the maximum of all children and use that.
A reftest is incldued that ensures a vbox wraps a label just like an
hbox does.
Benjamin Otte [Thu, 4 Nov 2021 14:56:37 +0000 (15:56 +0100)]
label: Redo measure() code
The old code couldn't properly do height-for-width because it only
computed the widest and smallest layout instead of looking at the actual
passed in for-size.
The label-sizing reftest has been adapted as the label code is now smart
enough to always display the whole text and no longer requests a too
small width-for-single-row when wrapping.
Yuri Chornoivan [Fri, 5 Nov 2021 18:46:16 +0000 (18:46 +0000)]
Update Ukrainian translation
Yuri Chornoivan [Fri, 5 Nov 2021 18:42:20 +0000 (18:42 +0000)]
Fix minor typo: Unsupportd -> Unsupported
Matthias Clasen [Fri, 5 Nov 2021 18:34:02 +0000 (18:34 +0000)]
Merge branch 'wip/carlosg/no-ping-serials-for-input' into 'master'
gdk/wayland: Do not use xdg_wm_base.ping serials as "user input" serials
See merge request GNOME/gtk!4122
Yuri Chornoivan [Fri, 5 Nov 2021 18:31:16 +0000 (18:31 +0000)]
Update Ukrainian translation
Timm Bäder [Fri, 5 Nov 2021 16:41:08 +0000 (17:41 +0100)]
paned: Don't pass values < -1 to gtk_widget_measure()
Fixes #4404
Caolán McNamara [Fri, 5 Nov 2021 14:03:47 +0000 (14:03 +0000)]
remove some unused declarations
Carlos Garnacho [Thu, 4 Nov 2021 13:40:21 +0000 (14:40 +0100)]
gdk/wayland: Do not use xdg_wm_base.ping serials as "user input" serials
Ping/pong serials are not meant to be interpreted as user input serials
(e.g. those given back later to the compositor on grabs). As a matter
of fact, Mutter uses a different count (i.e. timestamps) in these, so
using these serials may confuse the compositor into denying certain
operations like DnD.
Benjamin Otte [Thu, 4 Nov 2021 12:28:45 +0000 (13:28 +0100)]
Revert "label: Never measure more than max-width-chars"
This reverts commit
ba44e7a228534ff066694ad97d25eaa23ec5f3af.
The change was meant to revert to old GTK3 behavior but it actually
broke new GTK4 behavior that is in use where max-width-chars is used to
determine an ideal size, but where we don't want to limit the width to
that size.
So what happens is the reintroduction of GTK3-style lots of whitepsace
bugs, and we really don't want those.
We also don't want to break backwards compat if we can avoid it.
So let's revert this.
The reftest that was made for this purpose has been adapted.
Fixes #4399
Matthias Clasen [Thu, 4 Nov 2021 18:11:40 +0000 (18:11 +0000)]
Merge branch 'ebassi/cross-bundle' into 'master'
build: Don't use ld when cross-compiling
See merge request GNOME/gtk!4121
Emmanuele Bassi [Thu, 4 Nov 2021 13:41:35 +0000 (13:41 +0000)]
build: Don't use ld when cross-compiling
We can't guarantee anything on the target toolchain, in that case.
Matthias Clasen [Thu, 4 Nov 2021 11:06:44 +0000 (11:06 +0000)]
Merge branch 'taozuhong-master-patch-22982' into 'master'
Make dialog content_area box as vertical, keep compatibility with GTK3
See merge request GNOME/gtk!4119
TAO ZUHONG [Thu, 4 Nov 2021 08:25:03 +0000 (08:25 +0000)]
Update gtk/ui/gtkdialog.ui
TAO ZUHONG [Thu, 4 Nov 2021 08:23:04 +0000 (08:23 +0000)]
Make dialog content_area box as vertical, keep compatibility with GTK3
Matthias Clasen [Thu, 4 Nov 2021 01:58:56 +0000 (01:58 +0000)]
Merge branch 'listview-sink-adjustment' into 'master'
listbase: Sink adjustments
Closes #4403
See merge request GNOME/gtk!4117
Matthias Clasen [Thu, 4 Nov 2021 01:19:43 +0000 (01:19 +0000)]
Merge branch 'activate-signal-dropdown-combobox' into 'master'
Add activate signal to DropDown and ComboBox
See merge request GNOME/gtk!3935
Matthias Clasen [Thu, 4 Nov 2021 01:15:31 +0000 (01:15 +0000)]
Merge branch 'reftest-no-blink' into 'master'
testsuite: Set GDK_DEBUG unconditionally
See merge request GNOME/gtk!4116
Matthias Clasen [Thu, 4 Nov 2021 01:08:46 +0000 (21:08 -0400)]
listbase: Sink adjustments
gtk_adjustment_new returns floating objects.
Sink them.
Fixes: #4403
Matthias Clasen [Thu, 4 Nov 2021 00:43:01 +0000 (20:43 -0400)]
reftest: No blinking, please
Blinking cursors aren't helpful when we want to
compare renderings pixel-by-pixel. Turn them off.
Matthias Clasen [Thu, 4 Nov 2021 00:40:22 +0000 (20:40 -0400)]
reftest: Stop setting GDK_RENDERING
That environment variable isn't used anymore.
Matthias Clasen [Thu, 4 Nov 2021 00:39:33 +0000 (20:39 -0400)]
testsuite: Set GDK_DEBUG unconditionally
The default-settings key works in non-debug builds
too, nowadays.
Maximiliano Sandoval R [Sun, 3 Oct 2021 16:00:23 +0000 (18:00 +0200)]
combo_box: Use mnemonic_activate on override
This is changing the existing behavior where the mnemonic activation
would just grab the focus of the button, this was the behavior in GTK 3.
Maximiliano Sandoval R [Fri, 10 Sep 2021 13:42:47 +0000 (15:42 +0200)]
dropdown: Make DropDown activatable
The activation is simply forwarded to the button
within.
Maximiliano Sandoval R [Fri, 10 Sep 2021 13:42:15 +0000 (15:42 +0200)]
combobox: Make combo box activatable
The activation is simply forwarded to the button
within.
Benjamin Otte [Wed, 3 Nov 2021 22:22:30 +0000 (22:22 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
egl: Set the draw buffer to GL_BACK_LEFT
Closes #4402
See merge request GNOME/gtk!4114
Benjamin Otte [Wed, 3 Nov 2021 21:53:31 +0000 (22:53 +0100)]
macos: Fix return value
Benjamin Otte [Wed, 3 Nov 2021 21:51:39 +0000 (22:51 +0100)]
gdk: #if => #ifdef
Makes compilers happy
Benjamin Otte [Wed, 3 Nov 2021 18:49:08 +0000 (19:49 +0100)]
gl: Use GL_BACK_LEFT
The spec doesn't allow GL_BACK, but many drivers do. Use the
spec-accepted equivalent instead.
Fixed #4402
Benjamin Otte [Wed, 3 Nov 2021 18:49:57 +0000 (19:49 +0100)]
egl: Set the draw buffer to GL_BACK_LEFT
Instead of using GL_BACK, use GL_BACK_LEFT, because the spec demands
this (many drivers don't).
Also move the call from the GDK backends into the GLContext code, as
this is a generic EGL issue (nvidia being the main driver in need of
this call, see
9c4c4eaaa121d784f591a591b95264647eaece96 for a longer
discussion).
Fixes #4402
Matthias Clasen [Mon, 1 Nov 2021 19:38:55 +0000 (19:38 +0000)]
Merge branch 'small-check' into 'master'
icon: revert object-symbolic check to be smaller
See merge request GNOME/gtk!4110
Tobias Bernard [Mon, 1 Nov 2021 17:54:22 +0000 (18:54 +0100)]
icon: revert object-symbolic check to be smaller
The larger check works well in the headerbar, but not inline in various UI elements. This reverts the larger check since the latter is more common. For selection mode, a separate larger icon (selection-mode-symbolic) has been added to adwaita-icon-theme.
Matthias Clasen [Mon, 1 Nov 2021 15:22:53 +0000 (15:22 +0000)]
Merge branch 'ci-require-macos' into 'master'
Revert "ci: Allow macos to fail"
See merge request GNOME/gtk!4109
Matthias Clasen [Mon, 1 Nov 2021 14:33:09 +0000 (10:33 -0400)]
Revert "ci: Allow macos to fail"
This reverts commit
b7cab5c5ebd50e8102938ea87cedc48670837f4b.
We welcome the macos runner back.
Emmanuele Bassi [Mon, 1 Nov 2021 13:27:13 +0000 (13:27 +0000)]
Merge branch 'build-fix' into 'master'
build: Collect gi-docgen's common arguments
See merge request GNOME/gtk!4108
Emmanuele Bassi [Mon, 1 Nov 2021 13:00:51 +0000 (13:00 +0000)]
build: Collect gi-docgen's common arguments
And only enable `--fatal-warnings` if `-Dwerror` has been set, just like
we do for the introspection data generation.
Emmanuele Bassi [Mon, 1 Nov 2021 12:54:35 +0000 (12:54 +0000)]
docs: Add missing annotation
Emmanuele Bassi [Mon, 1 Nov 2021 12:54:07 +0000 (12:54 +0000)]
docs: Fix link to g_signal_emit()
Timm Bäder [Mon, 1 Nov 2021 06:42:54 +0000 (06:42 +0000)]
Merge branch 'fix_typo' into 'master'
fix typo in GtkDragSource doc
See merge request GNOME/gtk!4107
Alexandros Theodotou [Mon, 1 Nov 2021 03:48:52 +0000 (03:48 +0000)]
fix typo in GtkDragSource doc
GtkDrag => GdkDrag
Rūdolfs Mazurs [Sun, 31 Oct 2021 14:59:22 +0000 (14:59 +0000)]
Update Latvian translation
(cherry picked from commit
d67982d5e0d894aca1a61f5f7d26b8164f6842ae)
Timm Bäder [Sat, 30 Oct 2021 10:06:35 +0000 (10:06 +0000)]
Merge branch 'bilelmoussaoui/gi-docgen' into 'master'
gtk: fix broken gi-docgen annotation in IconView
See merge request GNOME/gtk!4106
Bilal Elmoussaoui [Sat, 30 Oct 2021 09:37:12 +0000 (09:37 +0000)]
gtk: fix broken gi-docgen annotation in IconView
Matthias Clasen [Fri, 29 Oct 2021 20:02:47 +0000 (16:02 -0400)]
4.5.0
Matthias Clasen [Fri, 29 Oct 2021 19:53:34 +0000 (19:53 +0000)]
Merge branch 'bilelmoussaoui/docs-typo' into 'master'
gtk: remove unneeded backtick from gi-docgen item
See merge request GNOME/gtk!4105
Bilal Elmoussaoui [Fri, 29 Oct 2021 18:32:06 +0000 (18:32 +0000)]
gtk: remove unneeded backtick from gi-docgen item
Matthias Clasen [Fri, 29 Oct 2021 17:19:22 +0000 (13:19 -0400)]
NEWS: Updates
Jordi Mas i Hernandez [Fri, 29 Oct 2021 11:45:56 +0000 (11:45 +0000)]
Update Catalan translation
(cherry picked from commit
ca02700a63b164a4670d0cde60bb0c279c7c4ec8)
Matthias Clasen [Thu, 28 Oct 2021 18:28:47 +0000 (18:28 +0000)]
Merge branch 'ebassi/editor-config' into 'master'
Add editorconfig file
See merge request GNOME/gtk!4102
Emmanuele Bassi [Thu, 28 Oct 2021 17:17:02 +0000 (18:17 +0100)]
Add editorconfig file
Editors that support configuration through the editorconfig spec:
https://editorconfig.org
should be able to have a subset of the GTK coding style and options
immediately available to them.
Plus, it's better than using relics from the Dark Ages, like modelines.
Carlos Garnacho [Thu, 28 Oct 2021 16:44:52 +0000 (16:44 +0000)]
Merge branch 'x11-xi2.4-gestures' into 'master'
Touchpad gestures for X11 (XInput 2.4, X Server 21.1)
See merge request GNOME/gtk!3610
Benjamin Otte [Thu, 28 Oct 2021 13:16:25 +0000 (13:16 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
cssparser: Remove unused argument
Closes #4381
See merge request GNOME/gtk!4101
Benjamin Otte [Thu, 28 Oct 2021 12:48:20 +0000 (14:48 +0200)]
broadway: fix texture upload
This was carelessly broken by me in
5b473911.
While fixing it anyway, at some support for better error handling.
Fixes #4381
Benjamin Otte [Thu, 28 Oct 2021 01:13:28 +0000 (03:13 +0200)]
cssparser: Remove unused argument
The base_directory argument is never used. So don't have it.
Matthias Clasen [Wed, 27 Oct 2021 23:50:13 +0000 (23:50 +0000)]
Merge branch 'gtkeventcontroller.c-fix' into 'master'
master: premature controller unreferencing in gtk_event_controller_handle_event
See merge request GNOME/gtk!4099
Matthias Clasen [Wed, 27 Oct 2021 23:27:42 +0000 (23:27 +0000)]
Merge branch 'rgba-for-master' into 'master'
docs: standard names are CSS names, not X11 names
See merge request GNOME/gtk!4100
Maxim Zakharov [Wed, 27 Oct 2021 00:37:36 +0000 (11:37 +1100)]
gtk: Hold reference on controller until events are fully handled
Fixes premature controller unreferencing in
gtk_event_controller_handle_event() if the controller itself is being
removed while handling the event.
Benjamin Otte [Wed, 27 Oct 2021 22:12:58 +0000 (22:12 +0000)]
docs: standard names are CSS names, not X11 names
We updated Pango a while ago to use these more common names, but apparently forgot the docs.
Matthias Clasen [Wed, 27 Oct 2021 19:37:01 +0000 (19:37 +0000)]
Merge branch 'wip/chergert/use-fabs-in-macos' into 'master'
macos: fix scale on macOS 12 beta
See merge request GNOME/gtk!4065
Benjamin Otte [Tue, 26 Oct 2021 23:43:46 +0000 (23:43 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
gdktypes: Remove GDK_EXTERN_VAR
Closes #4373
See merge request GNOME/gtk!4097
Benjamin Otte [Tue, 26 Oct 2021 15:02:56 +0000 (17:02 +0200)]
css: Don't throw warnings on broken URL in image css
If a URL can't be loaded, we might end up with a NULL file. Handle that
case properly by creating an invalid image instead and don't crash or
complain to stderr when files are NULL.
This was broken since
0886ade182f1a958024202d5c20248d57fcdb053
A new reftest has been included. We need a reftest instead of a
CSS parser test, because the error only becomes visible when
compute()ing the actual image.
Fixes #4373
Benjamin Otte [Mon, 25 Oct 2021 00:14:18 +0000 (02:14 +0200)]
gdk: Split enums from types
Add gdkenums.h for enums and keep gdktypes.h for types.
Makes both files easier to read.
Benjamin Otte [Sun, 24 Oct 2021 23:58:35 +0000 (01:58 +0200)]
gdktypes: Remove GDK_EXTERN_VAR
It is unused.
Matthias Clasen [Tue, 26 Oct 2021 17:53:06 +0000 (17:53 +0000)]
Merge branch 'bilelmoussaoui/missing-since-annotations' into 'master'
since annotations cleanup
See merge request GNOME/gtk!4086
Benjamin Otte [Mon, 25 Oct 2021 17:42:00 +0000 (17:42 +0000)]
Merge branch 'alatiera/gdk_create_context_nullable' into 'master'
gdkdisplay: Remove (nullable)
See merge request GNOME/gtk!4096
Rūdolfs Mazurs [Mon, 25 Oct 2021 16:59:50 +0000 (16:59 +0000)]
Update Latvian translation
(cherry picked from commit
4f5264d1b7dae98e1732d57098b9a7e4940964cd)
Jordan Petridis [Mon, 25 Oct 2021 15:40:40 +0000 (18:40 +0300)]
gdkdisplay: Remove (nullable)
gdk_display_create_gl_context only returns NULL when there is
an error set or asserts/aborts. So nullalbe annotation isn't needed.
Similar to
53312cf696516cdeb1c284008992022a210bb233
Emmanuele Bassi [Mon, 25 Oct 2021 08:22:44 +0000 (08:22 +0000)]
Merge branch 'enterprisey-master-patch-53741' into 'master'
readme: Fix "Building GTK" docs link
See merge request GNOME/gtk!4095
enterprisey [Mon, 25 Oct 2021 07:59:03 +0000 (07:59 +0000)]
readme: Fix "Building GTK" docs link
Matthias Clasen [Sun, 24 Oct 2021 19:04:48 +0000 (19:04 +0000)]
Merge branch 'wip/exalm/polish' into 'master'
A few inspector papercut fixes
See merge request GNOME/gtk!4092
Alexander Mikhaylenko [Sun, 24 Oct 2021 17:23:26 +0000 (22:23 +0500)]
inspector: Expand the controllers column view
Alexander Mikhaylenko [Sun, 24 Oct 2021 17:20:13 +0000 (22:20 +0500)]
inspector: Use .list for property list as well
Alexander Mikhaylenko [Sun, 24 Oct 2021 17:19:36 +0000 (22:19 +0500)]
inspector: Clean up the .list style
Make it work with the property list as well, handle spinbuttons, adjust
paddings so that buttons don't touch each other, don't override horizontal
padding unnecessarily.
Alexander Mikhaylenko [Sat, 23 Oct 2021 23:01:35 +0000 (04:01 +0500)]
inspector: Stop using .sidebar for the recorder page
Those aren't sidebars. Add separators manually instead of misusing the
style class.
Alexander Mikhaylenko [Sat, 23 Oct 2021 22:58:21 +0000 (03:58 +0500)]
inspector: Use consistent GtkTextView margins
Alexander Mikhaylenko [Sat, 23 Oct 2021 22:55:26 +0000 (03:55 +0500)]
inspector: Add a separator under toolbar in css editor
Same as object properties.
Alexander Mikhaylenko [Sat, 23 Oct 2021 22:22:56 +0000 (03:22 +0500)]
inspector: Use tabular figures for list position label
Avoid buttons jumping around while moving through list models.
Alexander Mikhaylenko [Sat, 23 Oct 2021 22:10:54 +0000 (03:10 +0500)]
inspector: Use .toolbar for toolbars
Remove all of the manual margins, spacing and has-frame=0, be more
consistent.
Alexander Mikhaylenko [Sat, 23 Oct 2021 21:53:22 +0000 (02:53 +0500)]
inspector: Use a GtkSeparator for the object details toolbar
Remove a hardcoded light grey border from the sidebar that was used for
this.
Alexander Mikhaylenko [Sat, 23 Oct 2021 21:51:07 +0000 (02:51 +0500)]
inspector: Remove list header style
The one from the theme works just fine.